fix: use internal run ids for job/result endpoints (SBP-421)#97
Merged
Conversation
vtnphan
approved these changes
Jul 9, 2026
vtnphan
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for a quick fix! Also tested locally, good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
SBP-421: now that we've implemented job queueing, workflow runs don't have a seqera ID initially. This PR changes all the job-related endpoints to expect and use the internal workflow run ID for lookups.
The backend is already providing the internal ID to the frontend for the job list, so we don't need frontend changes for this.
Changes
WorkflowRun.idvs.WorkflowRun.seqera_run_idfor lookupsidas the initial ID for all workflow run endpointsHow to Test
Run
uv run pytestType of change
Checklist